GROOVY-11601: remove support for expression list in for-each statement#2174
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2174 +/- ##
==================================================
+ Coverage 68.8710% 71.4704% +2.5994%
- Complexity 29570 35204 +5634
==================================================
Files 1421 1423 +2
Lines 113714 129434 +15720
Branches 19715 25501 +5786
==================================================
+ Hits 78316 92507 +14191
- Misses 28787 30202 +1415
- Partials 6611 6725 +114
🚀 New features to boost your workflow:
|
Contributor
|
It's better not to break existing users' code unless we have to do. |
Member
Author
|
Do you have an example of something that requires this? It is quite costly to support arbitrary expression list in for loop. |
Contributor
|
I added some example to the Jira and asked Jochen (via slack) if he had other examples (but he hasn't responded yet). |
Member
Author
|
sorry, I keep misinterpreting the icon in the branches list |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/GROOVY-11601